linzhe

Results 27 comments of linzhe

# Before [before demo](https://repl-vuejs.vercel.app/#eNp9kc1qwzAQhF/F7KmF4BzakzGBtuTQQn9oetTFtTeqUlkS0spVMX73SDL5OYTcduebgVlphAdjysEjVFC71gpDhUPyZsVUh1uh8FV3KG9G+jdYbcgKxafbxL4952iZqpdzLAbiQtgb2RDGrSjqTgyrEEK9TEOynmFYALlWq63g5c5pFQuMKcSg1b0REu27IaGVY1AVmSTWSKn/XrJG1uPioLc/2P5e0HcuJI3Bh0WHdkAGR0aN5UgzXm/eMMT5CHvdeRndV+AnOi196jjbHr3qYu0zX2773BttKb7bl1sHQuUOR6WiyTllP4P4C09XTj/VvSvvc46pCaY9CByW0A==) ![image](https://github.com/vuejs/repl/assets/40790268/139d7138-33ba-4a67-9004-479ee03a851e) --- # After [after demo](https://repl-git-fork-linzhe141-fix-ssr-vuejs.vercel.app/#eNp9kE9PwzAMxb9K5RNIU3eAU1VNArQDSPwR45hLlXglI02ixClBVb87SaqNHdBu9ns/y8+e4M7aegwIDbSeO2mp8kjBbpgWuJcan41AdTXRj8VmR07qfr5mul0vcMJSQzhY1RGmrqpaIcdNjLFd5yKjZzasgDw3ei/7+uCNTmunPMSAm8FKhe7VkjTaM2iq4mSvU8p8PxWNXMDVUeefyL/+0Q8+Zo3Bm0OPbkQGJ4861yMt9nb3gjHVJ3MwIqhEXzDf0RsVcsYFuw9apNhnXEn7OFjjKH3rw28jofbHo3LQTM6FZ5B+/3Dh9L+4N/VtmWN6hvkXCziSwQ==) ![image](https://github.com/vuejs/repl/assets/40790268/054a5b06-e5a3-4d5e-a2e3-825f7a1aadce)

@edison1105 I tried to fix it again, maybe it should be handled like this > I'm pretty sure the previous fix is proper.我很确定之前的修复是正确的。 Is there any reason why you changed...

It is similar to this issue https://github.com/vuejs/core/issues/12460 The root cause https://github.com/vuejs/core/pull/12482#issue-2700674082

Although `const {yyy} = defineProps({yyy:{}})` and `const props = defineProps({yyy:{}});const {yyy} = props` appear to be the same, they are actually compiled into completely different code https://github.com/vuejs/rfcs/discussions/502#discussioncomment-6544718 ![image](https://github.com/user-attachments/assets/8cb215a0-fa19-483e-a095-c75fc7c1293d)

> Through the example above,i guess the returned object of defineProps function should be a special shallowReactive one. Please confirm my thought, i would appreciate that. I have authored a...

> Sorry for the bump, but is there any chance it will get merged? Thanks a lot for your work @linzhe141 🙏 Maybe the current modification is not correct, so...

Thank you for your review. After giving it some thought, I also believe that adding a warning log is a good approach to inform users that Vue does not support...

> When the slot does not use style vars, should avoid changing the dom. ![image](https://private-user-images.githubusercontent.com/3705199/334740904-aa925ccb-58d9-4c78-b7d7-da44cb76a733.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTY5ODI4OTcsIm5iZiI6MTcxNjk4MjU5NywicGF0aCI6Ii8zNzA1MTk5LzMzNDc0MDkwNC1hYTkyNWNjYi01OGQ5LTRjNzgtYjdkNy1kYTQ0Y2I3NmE3MzMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDUyOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA1MjlUMTEzNjM3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YzlhYzdmNDZhNDA1NDQ5Yzg2MzkyZjFjODgzZTlhMjAyODg4N2JjNTdlZDU2ZmZkNzVmZjQxZjg1MTIwYzIwZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.xOAHwZM6jQdwnuD_WhzU6cFKA9n7CjeNUHDN-GtjkIY) --- When the `Teleport` does not use style vars, it alse changes the dom. So...