network

network copied to clipboard

Role not idempotent for infiniband interface

12

Hello, I've been trying out this role against a server that has both ethernet and infiniband interfaces, and I've found that the infiniband interface is continually updated on every run....

mjrasobarnett

The role ships a module (network_connections.py). It is not supported to use this directly but an internal implementation details. This should be mentioned in the README. It might also be...

tyll

Failures in the collection converted tests

8

Collections conversion tool for linux-system-roles converts the linux-system-roles tree structure to the collection tree structure and replaces the role value with FQCN in the yaml files as well as in...

nhosoi

https://github.com/linux-system-roles/network/blob/main/scripts/print_all_options.py allows to create an overview of all settings the role accepts. Use this to create an overview (maybe in the appendix) of the documentation and integrate this into the...

tyll

There is some tooling to provide coverage information for integration tests: https://github.com/linux-system-roles/network/blob/main/tests/get_total_coverage.sh Currently, this information is not yet used in the CI/not reported anywhere. It would be great to also...

tyll

Make yamllint config more strict

1

the truthy and document_start checks are currently disabled in yamllint by the system roles default template but they could be enabled for the network role The truthy check also allows...

tyll

Change ethtool features to use underscore instead of dashes

1

As discussed in https://github.com/linux-system-roles/network/issues/189#issuecomment-618020499, the ethtool features should use underscores instead of dashes. Since we already introduced the names with dashes, they need to be supported. Implementation plan: - [x]...

tyll

don't compare booleans, this was fixed only very recently: https://github.com/pallets/jinja/issues/813

4

don't compare booleans, this was fixed only very recently: https://github.com/pallets/jinja/issues/813 _Originally posted by @pcahyna in https://github.com/linux-system-roles/network/pull/232/files_

tyll

Currently, the tests use Ansible from the local host to run tests on the host specified in the inventory. The CI runner uses Fedora 32 for this. To test that...

tyll

Currently, the role will just fail in case NetworkManager-wifi is missing and network_allow_restart is not specified. It would be nice to add a proper error message and tests for this...

tyll