Linus Groh

Absolutely, I don't use these snapshots ever. Still seemed worth pointing out to avoid this situation, thanks for clarifying!

Crash with serenity's bdwgc patches before upstreaming: ``` 5.362 [#0 gctest(44:44)]: PV(error) fault in Region(0x00000020010bbd40)[0] at V0x0000000000145f90 5.362 [#0 gctest(44:44)]: Terminating gctest(44) due to signal 6 5.362 [#0 Finalizer Task(5:5)]:...

Thanks for the guidance! With `-O0 -DGC_DISABLE_INCREMENTAL`: ``` 8.170 CrashReporter(45:46): 0x00000001d83e902b: [/usr/lib/libsystem.so] syscall2 +0xb (syscall.cpp:25 => syscall.cpp:24) 8.170 CrashReporter(45:46): 0x000000121a1d645d: [/usr/lib/libc.so] abort +0x26 (stdlib.cpp:387) 8.170 CrashReporter(45:46): 0x000000194da22765: [/home/anon/gctest] block_unmap_inner +0xea...

- `-O0 -g -D GC_ASSERTIONS -D SMALL_CONFIG` works - `-O0 -g -D GC_ASSERTIONS -D SMALL_CONFIG -D GC_THREADS -D GC_BUILTIN_ATOMIC` works - `-O0 -g -D GC_ASSERTIONS -D GC_THREADS -D GC_BUILTIN_ATOMIC` crashes...

> Please remove `define MPROTECT_VDB' from SERENITY section in include/private/gcconfig.h Thanks, that does make gctest work with no additional build flags! > Also, I wonder about printed "using 1 marker...

Correct! I have to run the tests manually due to cross-compiling but it all seems to work:  > Could you please open a PR here? Sure - https://github.com/ivmai/bdwgc/pull/689

> Having the proposed patches, we do not need [SerenityOS/serenity@master/Ports/bdwgc/patches/0005-Make-the-collector-build-with-threads.patch](https://github.com/SerenityOS/serenity/blob/master/Ports/bdwgc/patches/0005-Make-the-collector-build-with-threads.patch?rgh-link-date=2024-12-15T18%3A22%3A42Z), right? The test runner still crashes with anything other than NTHREADS=0 so intend to keep that part of the patchset,...

I disabled it in https://github.com/test262-fyi/test262.fyi/commit/7bbd02c361e423dae2c1f49dd280a19d644fc67b because there's a bug where porffor processes would not terminate in a timely manner and eventually exhaust resources of the self-hosted runner. No one has...

Let's keep it open as a tracking issue, we'll want it back eventually :)

porffor was added back in v2