Lizzi Lindboe
Lizzi Lindboe
Looks good, just wanted to verify a few details, if you have input on any of them: 1. The error modal for "file too large" says "Close" on the button....
On item 3, to clarify, there are more fields! Sorry for the confusion. I think having the "Show more" pill is the appropriate way to go, since that's the way...
I think we're good, thank you!
@parasharrajat Hi, are you going to be able to review this PR soon?
@parasharrajat Looks like a significant change from upstream -- the `editMoneyRequest` command was removed entirely in favor of the more detailed, specific commands like `updateMoneyRequestAmountAndCurrency`. Easy to fix conflict-wise, but...
@parasharrajat Main is merged 👍
@parasharrajat Update pushed, the newer commands should be included now. > I noticed that I have to reselect either category or tag for outofPolicy violation to show up. So the...
@parasharrajat While I'm able to reproduce the "auto-set category" bug, I'm not able to reproduce the violation showing up for missing category anyways. I'm continuing to try. FWIW, I can...
@parasharrajat Looks like the auto-categorization is a server-side feature, so that's another issue this PR cannot address. https://expensify.slack.com/archives/C01GTK53T8Q/p1706221657329989, but I pinged you on the thread as well. For issue 2,...
> BUG: Looks like selecting the category does not remove the violation. Okay yeah, I can reproduce that bug. This didn't happen before, so something new is wrong, looking into...