Kenneth Lim

Results 443 comments of Kenneth Lim

This is kinda old but for me it is the same as before, I've monkey patched the FileReader stuff to be one line based on the blob that is already...

Really interesting ideas here, thanks @Qianqianye for pointing me to this issue. I didn't manage to have a look at the underlying code for the detections but for me the...

Sorry took a bit of time to get to this. @rohanjulka19 Very good investigative work to find this and a proposed implementation. I like this general idea with the `validateParameterWrap`...

@Garima3110 @davepagurek Just to mention that the test are expected to fail so if the implementation itself looks good it can be merged.

I'll close this in favor of the issue open in the web editor repo. Thanks @panna3, do let us know if you notice this outside of the editor as well...

Actually now that I thought about it, there probably should be a way to manually change the FES language if needed. I'll reopen this for possibly implementing something like that.

@Faisal-imtiyaz123 Sure but before writing any code and setting up a PR, can you share the implementation idea you have for this?

Going with the API suggested by @davepagurek make sense to me with attaching to p5.Element in general and having `.contextMenu()` as the method. One thing to keep an eye out...

@bojidar-bg I'm fine with leaving a few days for us to think about the implementation since this will be adding a new API which we want to avoid getting it...

Option 3 sounds good for now to have consistency with other event handling functions like `mousePressed()` so let's go for it. We can revisit and unify event handling with 2.0...