Lili Zoey

Results 166 comments of Lili Zoey

im working on `GodotString` and `StringName`.

> im working on `GodotString` and `StringName`. I've gotten a bit side-tracked. Feel free to have a look here if someone else wants to continue, https://github.com/lilizoey/gdextension/tree/feature/stringy-types. Though there are some...

> ... `is_equal_approx` should also be implemented, unless another trait accomplishes this. (`PartialEq`) That would be [`ApproxEq`](https://godot-rust.github.io/docs/gdext/master/godot/builtin/math/trait.ApproxEq.html).

i think this is related to #531 it'd probably be better to use c-string literals for this when it's stabilized (next rust release?). is there a reason you dont just...

We should probably just make `Array` ignore null values unless the `T` allows for null values (such as `Option` or `Variant`). I'm not sure if we should then remove the...

> Maybe we should automatically treat `Array` as if all elements were `Option` (i.e. indexing returns `Option`) if the editor allows for `T` to be null? I'm not sure if...

So the only case where our logic should fail here would be for inserting null objects into an `Array`. I think i'd still prefer removing them automatically here since `Gd`...

> `Gd` containing null is a non-starter, this would just introduce the Billion Dollar Mistake. it would be `Array` containing null values, but not allowing you to get a null-`Gd`....

> > > Is it possible for us to raise an error (one that does not crash the editor) when we get `null` for a `Gd` in an array (TODO:...

here's one way we could disallow it that lives entirely in the type system https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=834bb7d13150904d471eef57e73d1b66