Li Lin
Li Lin
This PR fixes issue https://github.com/go-playground/webhooks/issues/153
Adding more context to the above discussion regarding `reviewDecision`. As pointed out in https://github.com/runatlantis/atlantis/issues/2112#issuecomment-1116376830 and its following discussion, we might need to use the `reviewDecision` in GraphQL API as the...
> it doesnt look like atlantis passes userConfig down to NewGithubClient. I could definitely add that in, might be worth adding in the entire userConfig to allow additional flags to...
> might it make more sense to build a new "GithubConfig" struct, and pass that into NewGithubClient? That would give a sustainable, go-forward way to influence github-specific behavior in the...
@hatmarch It will be greatly appreciated if you can help us fix the conflict and possibly trim `res` and compare it against empty string first!
@andoriyu We reverted the code that caused the regression. Could you help verify if the issue is resolved in [v0.19.7-pre.20220713](https://github.com/runatlantis/atlantis/releases/tag/v0.19.7-pre.20220713)? Thank you!
@chicocvenancio Unfortunately we had to revert it due to the regression. However, https://github.com/runatlantis/atlantis/pull/2436 is another attempt to add in the feature without breaking existing use cases. It would be highly...