Lilian Anatolie Moraru

Results 48 comments of Lilian Anatolie Moraru

Yes. I have access to a Windows machine at work, I'll reconfirm today if this fixes the issue(or if it is necessary at all).

I see one more issue. https://github.com/alexcrichton/cmake-rs/blob/master/src/lib.rs#L516 : it handles only traditional PC architectures and panics otherwise. The CMake help indicates that you could pass "ARM" as an architecture.

I just tried it and seems like passing `Visual Studio 15` to `CMake` is also ok(in messages, the generator is transformed into `Visual Studio 15 2017`). The issue with ARM...

I could do that. What do you think would be the appropriate naming for these functions? I am thinking(inspired by `std::process::Command`) of: `cmake_arg/cmake_args` or `arg/args`? At least for me, `arg/args`...

Since "DEBUG"(the environment variable) is not a common and standardized variable for these situations, I think `cmake`(the crate) should not treat it in a special way. It's not hard as...

Shouldn't the compiler also have support for this(run-time feature detection)? Like [Intel Compiler's -ax flag](https://software.intel.com/en-us/articles/performance-tools-for-software-developers-intel-compiler-options-for-sse-generation-and-processor-specific-optimizations)? Or the different code paths just need to be created by the library and it...

@vorner > I'm not entirely sure how the hashes are computed.: That hash is a Build ID(sha1 on some info in the ELF header that identifies that specific build) that...

@gyscos Don't forget that using the `ncurses` backend, ncurses is still compiled in release mode, while only `cursive` will have unoptimized code. In the case of `termion`, since it's all...

I think `bcrypt` is a must-have.

@newpavlov There is also [this implementation](https://github.com/Keats/rust-bcrypt/blob/master/src/lib.rs) and [this one(which seems better but I'd switch it from `trait IntoBcryptSetup` to the yet nightly TryInto/TryFrom)](https://github.com/inejge/pwhash/blob/master/src/bcrypt.rs). The second also has the 72 bytes...