Colin Seymour
Colin Seymour
> * There's no tests to update for vendored files at the moment it seems) 👇 😉 https://github.com/github-linguist/linguist/blob/1040da7115035a67fd0b8bfeb12f38b9719b16af/test/test_file_blob.rb#L270
This doesn't appear to be particularly popular with search only returning 51 files within this path.
That's still incredibly low. The lack of indexing is generally a sign of a lack of activity. We switched the search backend a few years back and IIRC only index...
> @lildude would 200 repos be considered enough? Yeah, that seems reasonable to me.
> I assumed that >100 repositories would qualify. Is there a more specific threshold? https://github.com/github-linguist/linguist/blob/347e912ab9c7e3fbd4582d75eb3eebc8a06b868f/CONTRIBUTING.md?plain=1#L79-L80
Oh yes. Whoops.
> * https://github.com/ultraslayyy/linguist/blob/main/samples/XML/Win64.pubxml A link to your fork of this repo is not the original source. Please update this link to the original source of the sample and state the...
Ooops. I forgot the XML strategy test needs modification too. You can fix the failing test by adding the sample path to the array in the test: https://github.com/github-linguist/linguist/blob/2409807814a3ff386294b1f217b886a1594642cd/test/test_strategies.rb#L176-L195
I'm don't think this should be pulled out into it's own entry as Premake appears to be a build system, like Bazel, that is written in Lua and not it's...
You've not resolved the ordering test failure.