Colin Seymour
Colin Seymour
> Am I in the right direction? Yup. That's the right thing to do.
I tried this in the past and it broke things and I didn't have time to investigate further ([revert PR](https://github.com/github-linguist/linguist/pull/5915)). It was over two years ago so maybe things are...
> do you recall what broke? I don't specifically, but from my comment in https://github.com/github-linguist/linguist/pull/5912 checkout depth was at least one problem. We need more than `master` for our tests...
That looks to be left over from when I was tatting with this last time, so maybe I've already fixed that issue 😁 I note your test PR only updates...
There's no need to close this.
This appears to have overlap with https://github.com/github-linguist/linguist/pull/7163 and like that PR I think this should really be rolled into INI. As you're moving the `.service` extension @Alhadis's [comment](https://github.com/github-linguist/linguist/pull/7163#discussion_r1900085333) might be...
> The addition of `.conf` reconciles this PR and #7163, so this PR now covers all extensions that hit the usage minimums between the two. `.conf` is faaar too generic...
Oh yes. Nice find @DecimalTurn. I think your suggestion makes sense with that in mind.
> What is the threshold? https://github.com/github-linguist/linguist/blob/5fad8d57605a914026a65b0e3ff6815d739944de/CONTRIBUTING.md?plain=1#L76-L80
Please merge main into your branch. Your branch is still showing signs of https://github.com/github-linguist/linguist/issues/7145 which has been resolved now.