Colin Seymour

Results 237 comments of Colin Seymour

> Any thoughts as to why these numbers (GitHub search vs. GitHub API) might be off and when we can expect GitHub search to update? Yes, GitHub search does not...

> Seems we'll have to make some changes with the grammar. I'll try to submit a few PRs later this week to resolve it. Really? The current test failures aren't...

> I ran some private tests with the grammar shortly after seeing those failures, and eleven errors had shown up, apparently due to some backtracking issues with the language. I'd...

> Although when I last tried to add to linguist locally I also experienced issues where the linguist TextMate grammar parser does not support non-fixed lookbehind (whilst VSCode does) If...

> I expect this PR to immediate go into "Pending Popularity" Yeup 😁 … only 350 files with that extension so it's likely to be a while before this is...

> I previously figured we met that requirement as we there are over 500 SurrealQL files on GitHub, excluding possible inline SurrealQL queries. Our current assessment guidelines are detailed in...

> Is this still the case? Yes > Is there a way to get the tree-sitter grammar into Github by any chance? No > The textmate grammar supports JSDoc injections,...

There’s no rush and not need to rebase as this PR won’t be merged until close to the next release anyway and that will include a merge update if needed.

That would probably be best short of relicensing the current repo, but that's entirely up to you. We can't accept the current repo as it stands with the GPL-3 license.

> Should I rerun something to account for that? Yes. Re-running `script/add-grammar --replace...` like you did when switching the grammars should pull in the updated license file.