Like Ma comments

Results 14 comments of


Like Ma

MEM_Connector: Fix CID 1442918

@jwillemsen What about it? Although it is detected by Coverity, it is a bug indeed. But it is hard to reproduce it.

Avoid allocating buffer when printing log.

The size of verbose buffer on stack is `VERBOSE_LEN` + 1 = `129`. Is it too large for embedded systems? ```cpp /// Size used by verbose mode. /// 20 (date)...

Avoid allocating buffer when printing log.

Yes. I separate a line of log message into a prefix (`verbose` buffer) and content so that only prefix needs a small buffer on stack.

Avoid allocating buffer when printing log.

I find that ``` /// Size used by verbose mode. /// 20 (date) + 15 (host_name) + 10 (pid) + 10 (type) /// + 4 (@) ... + ? (progname)...

Fix assigning not null-terminated string.

> Please extend one of the unit tests under ACE/tests with a reproducer It may not be do it easily. https://docs.microsoft.com/en-us/windows/win32/api/winreg/nf-winreg-regqueryvalueexa#remarks shows >If the data has the `REG_SZ`, `REG_MULTI_SZ` or...

ACE_UNIX_Addr supports abstract path in Linux.

> Any test? It is already in `ACE/tests/UNIX_Addr_Test.cpp`

ACE_UNIX_Addr supports abstract path in Linux.

> But does it contain a test for an abstract path? I mean that I committed a test for it: https://github.com/DOCGroup/ACE_TAO/blob/cf8f8f27f064b9e62bd0f0876d0178e197197518/ACE/tests/UNIX_Addr_Test.cpp#L58-L74

ACE_UNIX_Addr supports abstract path in Linux.

> Ok, missed that addition. Can you merge master into your branch so that all recent CI builds run? Done

How to get the number of event handlers in ACE_Reactor?

No. I tried `ACE_Reactor::size` before. When the implementation of `ACE_Reactor` is `ACE_Select_Reactor`, `ACE_Reactor::size` gives the capacity of the file descriptor table.

How to get the number of event handlers in ACE_Reactor?

I find that no code used `ACE_Reactor::size()` or `ACE_*_Reactor*::size()`. They are not consistent: * `ACE_WFMO_Reactor`: the **capacity** size https://github.com/DOCGroup/ACE_TAO/blob/94ee14a015c942500cbd06316dd07de2b540e6b4/ACE/ace/WFMO_Reactor.inl#L1173-L1178 * `ACE_Select_Reactor`: the **capacity** size https://github.com/DOCGroup/ACE_TAO/blob/94ee14a015c942500cbd06316dd07de2b540e6b4/ACE/ace/Select_Reactor_T.inl#L225-L229 https://github.com/DOCGroup/ACE_TAO/blob/94ee14a015c942500cbd06316dd07de2b540e6b4/ACE/ace/Select_Reactor_Base.inl#L6-L14 https://github.com/DOCGroup/ACE_TAO/blob/94ee14a015c942500cbd06316dd07de2b540e6b4/ACE/ace/Select_Reactor_Base.cpp#L82-L105 * `ACE_Dev_Poll_Reactor`: the...