liho745

The title/description of this PR can be revised to be more accurate. Since the ocean is only invoked as the boundary condition to the river, what'd done is here not...

@fdongyu Thanks for the explanation. Could you further revise the PR description to 1) revise the part mentioning routingmethod since you've made the change in RtmMod.F90, 2) add a bit...

> @liho745 Please define 0.95 as a constant variable and provide description. Done.

> We have detected another bug that is related to MOSART-WM but had not been picked up by the developer tests. I am currently working on it. Hopefully, fix it...

@bishtgautam Do you have any remaining comments? If not, could you approve the PR?

> Yes.

> status: needs another PR #5454 which updates tests first. Not needed for v3. Integrator has tested and one test is failing for unknown reasons. @bishtgautam Are you the integrator?...

> I had incorrectly resolved the conflicts in `driver-mct/main/prep_rof_mod.F90` that caused the `ERS.ne30pg2_r05_EC30to60E2r2.GPMPAS-JRA.compy_intel.mosart-rof_ocn_2way` test to fail. After correctly resolving the conflict, the test passes. @bishtgautam Thanks for resolving the test...

@tanzeli1982 @hydrotian I could be wrong, but my impression is that MOSART_sediment was integrated before adding the dam_built_year capacity, i.e., when there was no specification of reservoir construction years. In...

I've fixed this bug on a branch created off the E3SM master. https://github.com/liho745/E3SM/tree/liho745/river/bug-fix-no-sed-trapping-before-dam-construction. I did not do it on a branch created off the commit introducing MOSART-sediment or dam construction...