Sagar Seth

Results 13 comments of Sagar Seth

Hi @derberg , @AayushSaini101 , I found the root cause of the Babel de-optimisation warning, it comes from **generator-react-sdk**, because `asyncapi-ui.min.js` (500KB+) gets passed into Rollup/Babel The fix is simply...

Hey maintainers, I need a bit of advice. For now I have fixed the `Babel deoptimisation warning`, so that part is clean now... However, I still see this Node.js warning...

sorry @SHUBHANSHU602 , I am working on this issue. please look for the stale issue or some other issue in the mean time.

Note: After fixing this and **changing** the value from the string "false" to the boolean false, the CSS/JS will generate correctly🫡 By using `asyncapi generate fromTemplate test/spec/asyncapi_v3.yml ./ -o dupa...

yes, that makes sense. your solution is definitely more robust. using `Object.prototype.hasOwnProperty.call(...)` handles both JSON and JS-generated templates safely, and avoids any issues with falsy defaults or prototype-less objects. thanks...

@derberg I noticed coderabbit flagged a bunch of issues in files I didnt touch (Keeper, WebSocket client templates, Constructor.js, etc) looks like these came in from the recent merge into...

yup, you guys are correct, both of them were right about the root cause. the default value check was skipping parameters with `default: false`, so singleFile was never injected into...

@derberg , i noticed Babel prints warnings directly to stderr, so Rollup doesnot catch them, to follow your suggestion, i modified the transpiler so: - babel warning are suppressed by...