lightclient
lightclient
I added a few more tests here. It didn't seem like the included test was really verifying the port was loaded correctly. Also verifying we don't return an endpoint with...
Right, but this also works: ```console $ go run ./cmd/geth attach --datadir=~/.ethereum/sepolia ``` So I feel like blsync isn't consistent?
This PR is quite stale, going to close for now. Please reopen once you rebase and want to continue pursuing.
`DeleteMapping` was added in #15222 to fix issue #1024, but this is before `addAnyPortMapping` was added in #26359. I'm not really sure the point of removing it? But at the...
Agree with Sam. Will err on side of caution and simply close this PR.
``` --- FAIL: TestWalletNotifications (0.54s) keystore_test.go:427: wallet list doesn't match required accounts: have 429, want 428 keystore_test.go:455: can't find event with Kind=0 for 253061228b716cd444ccc9f3381792b538310045 FAIL FAIL github.com/ethereum/go-ethereum/accounts/keystore 8.741s ``` https://ci.appveyor.com/project/ethereum/go-ethereum/builds/51423452/job/wfloegv6xd3i9yo4
``` --- FAIL: TestSimulatedBeaconSendWithdrawals (12.09s) simulated_beacon_test.go:139: timed out without including all withdrawals/txs FAIL FAIL github.com/ethereum/go-ethereum/eth/catalyst 14.916s ``` https://ci.appveyor.com/project/ethereum/go-ethereum/builds/51457716/job/m50ess4o9qc47fur
``` --- FAIL: TestBindings (129.24s) bind_test.go:2102: tmpdir /tmp/TestBindings1034863270/001/bindtest bind_test.go:2160: failed to run binding test: exit status 1 ``` https://ci.appveyor.com/project/ethereum/go-ethereum/builds/51809451/job/201lshrjwbuq1jr0
This clarification makes sense and is in general how I anticipated the EIP to be implemented. Currently the EIP doesn't specify that the auth list accounts should be considered "created...
I don't think SELFDESTRUCT should revert the deployment of a delegation designation. It isn't added to the list of "deployed contracts" during the tx for a reason.