Jesse Hallam comments

Results 140 comments of


                                            Jesse Hallam

Replace Hard-coded HTTP Verbs with Constants

Thanks, @lindy65! Feel free to merge when ready, @enzowritescode :)

Handle case where sidebar API endpoints return null

Go for it, @fmo00!

Add FIPS compliance to agents plugin

@crspeller, can we keep this open until we ship proper FIPS support in the plugin? We're using this PR to build FIPS-compliant versions with each release (a manual effort @agarciamontoro...

RN Apps: DeepLinks are not working correctly

Taking this one internally.

RN: font display issue on thread list items in threads view when mentions are used within title

Taking this internally.

[MM-63805] Don't throw a MFA warning for unauthenticated plugin requests

> All the code you commented on is part of the if statement that starts with L202. My PR actually doesn't change any code inside that statement. Given that there...

[MM-63805] Don't throw a MFA warning for unauthenticated plugin requests

Thanks for the clarification, @esarafianou! @hanzei, thoughts on just removing the double logging but otherwise leaving this logic unchanged?

fix: add nil check for document after parsing OpenAPI spec

Hi @ablazejuk, looking at the source for `libopenapi`, this method cannot return a `nil` document without returning a `nil` error: https://github.com/pb33f/libopenapi/blob/5ac86575331613787bb3a0ec852762ad0a7f9699/document.go#L135-L148

Always require signatures for prepackaged plugins

I've tested this build with the Cloud test server (including HA), verifying our default pre-packaged plugins load normally, and I can continue to install from the marketplace. Let's continue to...

Added urgent_mentions_count column to mychannel table

Closing this to restart with SET.