Jesse Hallam
Jesse Hallam
Swapping @sbishel for @crspeller given the dual overlap of Playbook and the "Fast Futures" nature of this initiative.
> I don't see any current security problems, however it seems unlikely that we found them all in this unconventional flow. Thanks, @crspeller! @esarafianou, I know you took a look...
Thanks again for your efforts, @wetneb -- taking this one internal for now.
Looks to be an issue with previous commits -- @yasserfaraazkhan, do you know what might be causing this?
Closing old change, not likely to take action directly from here, but will revisit from first principles if needed.
@mgdelacroix, just a reminder re: this pull request. If you can't get to it, can you let me know so I can find another reviewer?
:wave: @enzowritescode! Our vet check for the API is housed over at [github.com/mattermost/mattermost-govet](https://github.com/mattermost/mattermost-govet/blob/new/openApiSync/openApiSync.go). It's a bit clunky at present, with a primary purpose of ensuring we don't forget to document...
Looks good! This would be a good API to run the full E2E suite on, but I can't find the label to trigger that -- pinged over at https://hub.mattermost.com/private-core/pl/xsec161tapyq3bu1e6g1c6d13y.
@lindy65, given the successful e2e pass above as well as the nature of this change, I don't think any explicit QA is required. Can you let us know your thoughts?