David Li
David Li
Updated again, since @jvanstraten pointed out that the server may want to know the client's Substrait release version since otherwise it may be unclear how to interpret the plan (even...
Rebased + updated (minus the timeout since we'd have to change the result set schema for GetSqlInfo to add floating point)
Updated, thanks Antoine!
CI failures here are addressed/fixed elsewhere
Looks like it still doesn't build on 32-bit Windows and there are tons of compiler warnings about casts (one of which is an error). We might want a general way...
FWIW, an explicit static_cast is enough to suppress the warning. I'm more thinking: on 32-bit platforms, do we also want to check for potential overflow?
Fair, though ChunkedArray and IPC may throw that off? I suppose we only need to check in certain places for that though
@jduo you can use Archery for autoformatting: https://arrow.apache.org/docs/developers/cpp/development.html#code-style-linting-and-ci
@jduo can you rebase here? The autotune, weirdly enough, does not actually kick off CI.
@jduo it turns out ARROW_SUBSTRAIT implies ARROW_PARQUET so we should turn that off, too