David Li comments

Results 383 comments of


                                            David Li

ARROW-15961: [C++] Check nullability when validating fields on batches or struct arrays

Hmm, fair. I filed ARROW-16116

ARROW-15961: [C++] Check nullability when validating fields on batches or struct arrays

See #12829 for an attempt at fixing the Parquet issue properly

ARROW-15961: [C++] Check nullability when validating fields on batches or struct arrays

@kaoutherab try rebasing this PR now (but omitting the last commit to avoid conflicts)

ARROW-17377: [C++][Docs] Adds tutorial for basic Arrow, file access, compute, and datasets

thanks for these! I'll try to take a look when I get a chance (…and get you that Flight tutorial sketch as well)

ARROW-17377: [C++][Docs] Adds tutorial for basic Arrow, file access, compute, and datasets

@github-actions crossbow submit cpp-tutorial-example

ARROW-17377: [C++][Docs] Adds tutorial for basic Arrow, file access, compute, and datasets

As for the references, I think we don't actually add the Sphinx directive to put the docstrings into the actual docs for each of the individual functions, so Sphinx doesn't...

ARROW-17377: [C++][Docs] Adds tutorial for basic Arrow, file access, compute, and datasets

CI failures look to be unrelated.

ARROW-16000: [C++][Python] Dataset: Alternative implementation for adding transcoding function option to CSV scanner

That sounds like dataset inspection is being done without the transcoder actually being set. I think we do need the test to work. I would expect latin-1 happens to work...

ARROW-17289: [C++] Add type category membership checks

Note #13753 removes the `*Types()` anyways. I'm -1 on the PR as is, but I think we should add the missing `is_*(Type::type id)` functions, and I think it's fine to...

ARROW-17289: [C++] Add type category membership checks

I think you can ignore those, some files need to be bumped post-release