Markus Klein

Results 142 comments of Markus Klein

> `{phone}` That's indeed a good one. Didn't think of the plus being eaten up by `is_numeric`.

> away from regexp, to lexing to be very honest: I'm damn surprised how well regexp actually worked for us so far. But I'm fully aware that this is a...

Why specify the data attribute then at all if default `null` is the goal?

> in my opinion the documentation could be improved; as it is now, it is somewhat misleading Indeed this is a bit unfortunate. What is being described is the JS...

Feedback to your report: 1) Not everyone is using Joomla - don't expect others to install it just for debugging 2) What is the error message? 3) How do you...

https://github.com/heiseonline/shariff/blob/develop/src/js/shariff.js#L256 lacks the IE specific options as documented for instance here: https://www.w3schools.com/jsref/met_win_open.asp `resizable` is one of those

Don't know. The maintainers needs to say this. I would opt for integrating the window size in the various service modules. Other than that simply enabling most of the options...

guess because bower died already? simply use the npm package and there's a dist folder.

Well, I can't tell you that, I didn't change it ;-) Since bower was officially deprecated we moved all our projects away from it. Either to npm or to composer...

Try v2.0.1