shariff icon indicating copy to clipboard operation
shariff copied to clipboard

'dist' directory missing if loaded via bower

Open Serifenlos opened this issue 7 years ago • 6 comments

I get my components with the CodeKit-App. After I updated form version 1.26.1 to the newest, I can’t find "shariff.min.js". Ok, the bulid-folder is droped, but where can i get the javascript-file? I didn’t get the dist-folder. What’s wrong?

Serifenlos avatar Jan 19 '18 00:01 Serifenlos

Why doesn't that get solved and everyone is now forced into compiling. Isn't Shariff meant to be easy and hassle-free to use? Alternatively, why not at least simply serving another bower git repo with the compiled version?

tbba avatar Apr 19 '18 20:04 tbba

guess because bower died already? simply use the npm package and there's a dist folder.

liayn avatar Apr 19 '18 20:04 liayn

I wonder why you make life difficult forcing others into a certain technology and not simply providing the compiled files for the rest of who are not so religious about npn?

tbba avatar Apr 19 '18 20:04 tbba

Well, I can't tell you that, I didn't change it ;-)

Since bower was officially deprecated we moved all our projects away from it. Either to npm or to composer (for PHP projects).

liayn avatar Apr 19 '18 20:04 liayn

Ok, the bulid-folder is droped, but where can i get the javascript-file? I didn’t get the dist-folder. What’s wrong?

@Serifenlos The build artifacts have been removed from the repository. They are still available via the npm package and the GitHub release page.

After I updated form version 1.26.1 to the newest, I can’t find "shariff.min.js".

@Serifenlos Removing the build artifacts from the repository was a breaking change. That is being signalled by the major release and a warning in the release notes and the changelog. Updating dependencies of a project to a different major release means that you cannot expect stuff to just keep working. See semver.org for more detail.

Why doesn't that get solved and everyone is now forced into compiling.

@tbba We do not force you to do anything. You chose to use shariff.

Isn't Shariff meant to be easy and hassle-free to use?

@tbba That is why we provide compiled release files and a tutorial.

Alternatively, why not at least simply serving another bower git repo with the compiled version?

@tbba Because bower is dead.

I wonder why you make life difficult forcing others into a certain technology and not simply providing the compiled files for the rest of who are not so religious about npn?

@tbba Again, we do not force you to do anything. Also, we provide the compiled files via the npm package and the GitHub release page.

compeak avatar Apr 20 '18 06:04 compeak

@compeak , In my humble opinion, for Mac coders, using CodeKit, as example, bower still does make a lot of sense. You might call Bower "dead" in your world, but it is still supported nicely with then-thousands of useful libraries. Even shariff is still offering decent bowser support by sending out update notices - just that those updates are crippled now.

You chose to use shariff.

Yes and no :-) The DSGVO is forcing us into it because it is half-officially recommended, if you want to do EU-privacy right. - And Shariff is really very, very good at that, that is for sure and I am very thankful it exists. I just think that the release policy/ politics is more strict than it needs to be for a software with that broad use. What does it hurt to provide those 2 precompiled files somewhere in the library.

Yes, you are also distributing compiled release files, great. But see it from a different angle: They come zipped and it needs more manual steps to update. Fixing security flaws can be delayed that way.

tbba avatar Apr 22 '18 12:04 tbba