Ismail Khoffi
Ismail Khoffi
As per #238 `int`s, `int32`s, and `int64`s aren't zigzag encoded by default. Add a tag such that developers can still zigzag encode. If they need to encode ints which often...
It is possible to write custom (un)marshallers in amino. This isn't documented, neither is there an interface that clarifies which methods need to be implemented (an equivalent of https://golang.org/pkg/encoding/json/#Marshaler for).
Amino allows to encode `int` for convenience and while the underlying varint encoding doesn't waste bytes on the wire it remains unclear how this translates to the existing proto3 types...
Not too long ago the code snippet below produced a 100KB JSON message which consumed about 1,3 Gb memory while decoding. ```go package main import ( "strings" "github.com/tendermint/go-amino" ) type...
Give callers the possibility to handle certain errors by introducing sentinels where appropriate. Suggested by @xla here: https://github.com/tendermint/go-amino/pull/190#discussion_r196610287
add a test case that fails before #180 was merged (and check for general test-coverage while at it): ```golang cdc.RegisterInterface((*Packet)(nil), nil) cdc.RegisterConcrete(PacketPing{}, "tendermint/p2p/PacketPing", nil) cdc.RegisterConcrete(PacketPong{}, "tendermint/p2p/PacketPong", nil) buf := bytes.NewBuffer(nil)...
As suggested by @jleni: Instead of manually testing compatibility between the KMS and tendermint we could add some kind of integration test which spins up everything needed to have a...
## Summary Quoting celestiaorg/celestia-node#1133: > Partial storage nodes are nodes that only store some of the blocks in the blockchain, and can be queried by any other nodes (including light...
Partial nodes map to storage nodes in the original paper. IMO, the specification should mention this fact but independently of the original paper the specification should also mention the role...
This gives a better overview of the differences and similarities of the existing types.