Liam Don

Remove mode option from texture.lock() and clarify types in JSDoc for getSource/setSource

6

**[Updated PR based on discussion below]** [Texture.lock](https://developer.playcanvas.com/en/api/pc.Texture.html#lock) accepts a `mode` option, which can be either `TEXTURELOCK_READ` or `TEXTURELOCK_WRITE`. Currently, this option has no effect. This (revised) PR removes the `mode`...

Just a small improvement - `drawInRect` performance is very slow, and this method is faster. https://developer.apple.com/library/content/qa/qa1708/_index.html

Regarding the [`useGlobalPCUI` change in index.js](https://github.com/playcanvas/pcui-graph/compare/master...classdojo:pcui2.3.0?expand=1#diff-bfe9874d239014961b1ae4e89875a6155667db834a410aaaa2ebe3cf89820556R81): is this acceptable, or was there a reason to whitelist only some components? If so, how should they be required following the [email protected] build...

The lookup table approach is really neat, but after running some benchmarks it looks like we can get a ~10-15x speedup by using the built-in `Math.clz32()` ### Benchmark ``` let...

texture.lock({ level: 0 }): only upload a single mip level if locked explicitly

5

I also have some questions about future directions `texture.lock()` API, which I would be happy to help implement. I'm asking these in the context of #6003 - I kept that...

4.0.0 Resolve PRs, upgrade modules, fix tests + syntax for supported node versions

1

## Proposed major version update This is a wonderful project, but because change is constant in the JS world, it now has some small barriers to adoption in newer projects....

Feature request/usage question: toggle column visibility?

2

First off, thanks for this fantastic library - I have found it very useful for streaming output from a multiprocess build/watch system. My question: does the current implementation provide any...

Keep correct paths for build output even when build is invoked outside of repo root

2

This fixes a (possibly niche) problem that occurs when PlayCanvas is included in a monorepo with a central build system like [turborepo](https://turbo.build/) or [pnpm workspaces](https://pnpm.io/workspaces). The problem: build output paths...

Fix particle system with unlit mesh emitter

2

Currently, mesh particle emitters with `lighting: false` will not render in either WebGL2 or WebGPU. For a repro, look at https://playcanvas.vercel.app/#/graphics/particles-mesh and toggle the `lighting` option. I think the main...