Liam Defty

Results 9 comments of Liam Defty

@w3bdesign Just noting an additional change would be needed for React 18 support which I've outlined in https://github.com/ctrlplusb/easy-peasy/issues/741#issuecomment-1189533975 I'm also really keen to get react 18 support merged, is there...

Just noting that from my findings another change is needed for react 18 support In React 18 the FunctionalComponent interface has changed. The PropsWithChildren type is omitted which means a...

@ctrlplusb Firstly, I love this lib. Use it on a few projects and it's helped me loads. I'm keen to look at react 18 support, if it's something you don't...

@t-kelly Yep totally agree, that makes a lot more sense! 👏 @chrisberthe Yep, I can make some time over the next week or so to take a look :)

Hey @chrisberthe Thanks for replying! This was a while ago so let me try and jog my memory a little 🤔 Those two solutions are definitely viable options. However there...

@Cam would this not mean there are more requests than needed? In the update example, it would be more efficient to send a single request with the final quantity instead...

@cam Fair enough :) Personally, I think having the option to cancel requests could be beneficial in a few other use cases and because of the way this is implemented...

@Cam Apologies for the delayed reply - that makes sense! :)

@philipjohn @jasonagnew This is likely related to this https://github.com/Automattic/liveblog/blob/master/src/react/Editor/convertFromHTML.js#L23. Text element attributes need to be mapped from HTML attributes to props that React understand.