Liam Cain

Results 195 comments of Liam Cain

I wasn't able to reproduce the issue with the settings configuration that you provided, but I hadn't considered that you were syncing from multiple devices. > I have a guess...

Oh very strange. Sounds like a bug, sorry about that! If you restart Obsidian it should stop syncing. Otherwise there's a toggle to disable the automatic syncing in the settings...

Interesting, sounds like this broke from the Obsidian update. I'll take a look this weekend.

Hi, sorry for the long delay in reviewing. I went through your code and found a few of small issues. Just ping me when these get addressed and I think...

- [const markdown = fileview?.containerEl?.innerText || '';](https://github.com/joerncodes/obsidian-readwise-reader/blob/96105e305dba4aa8f1e03b00c8012b963cc29969/main.ts#L69) instead of this hack, you can use [`editorCheckCallback`](https://github.com/obsidianmd/obsidian-api/blob/9bb30633586c6649474b2affdf5b87efdd86498f/obsidian.d.ts#L518) to read the file using the Editor interface. - [rawFrontmatter](https://github.com/joerncodes/obsidian-readwise-reader/blob/96105e305dba4aa8f1e03b00c8012b963cc29969/src/frontmatter/frontmatterparser.ts#L21) There's no need to parse...

Hmm, I'm not sure how/why this pull request got closed. Github doesn't even say when it happened! I reopened it and can review it tomorrow.

Okay, so... November 3 is a little bit later than September 22 😬. Sorry for the long wait. I'm looking at this now. @Quorafind As for why this pull request...

Actually, I'll just close this pull request for now since it's not reachable anymore.

You might want to consider working combining this with the Task Collector plugin (https://github.com/ebullient/obsidian-task-collector). It has a simpler purpose and adding a command to cycle between task states might be...