liamaharon

Results 64 comments of liamaharon

> > @kianenigma am I right to assume we'll want to make it easy to test these with try-runtime-cli? Ideally should be as easy as `on-runtime-upgrade`, maybe make it auto-mine...

@d4h0 's solution worked for me in VSCode with a minor tweak. Instead of setting the profile on the `checkOnSave.extraArgs` I set it on `cargo.extraArgs`, otherwise `rust-analyzer` used `target/debug` when...

There is no difference between Etheruem mainnet and testnet addresses. You'll probably find the same thing for XRP addresses.

> > within 3 months at which point the transfer alias will be removed. > > Looks like it should be removed by now cc @juangirini

@juangirini I dismissed @ggwpez's review since his suggestions have been addressed. You should be able to merge now.

I'm planning to start on this soon, after I wrap up my current main work effort (lazy-download).

> simpler understanding. `#[pallet::storage_version]` is too much magic. The only issue I can think of with removing this is that we would not know what initial on-chain version to set...

> > First, I would remove `#[pallet::storage_version]` aka `current`. > > To what version are you then setting the storage version in the genesis state? I'm with you that we...

Moved: https://github.com/paritytech/try-runtime-cli/issues/9

> Why don't we start working on a new `construct_runtime!` syntax, instead of trying to add more to the current macro. paritytech/polkadot-sdk#232 there was already quite some discussion and the...