Liam Stevenson

Make SubscriptionValue public

4

`SubscriptionValue` is seemingly needlessly private at the moment, and it is the only implementer of `LeafAction` that is private. This pr makes it part of the public api. I have...

`case-analysis` fails to load module

2

See the below cram test: ``` Create the types Box.t and Either.t, each of which are in their own module and file. Box.t depends on Either.t. $ cat >either.ml EOF...

Optional argument include by `case-analysis`

1

With the file `test.ml`: ``` let foo ?bar x = x let () = foo () ``` running ``` $ ocamlmerlin single case-analysis -start 3:10 -end 3:15 -filename test.ml <...

Incorrect module type from `type-enclosing`

1

With `test.ml` having contents: ``` include struct open struct let hidden = 3 end let visible = 4 end ``` I get the following unexpected behavior: ``` $ ocamlmerlin single...

Jump to incorrect module

2

Hi, I've recently joined the Jane Street compiler team. We've had a user report a bug, which I've included reproduction steps for below. Essentially, there is an `import.ml` file, which...

Jump to definition with let-punning

1

Consider the program: ```ocaml let (let+) x f = List.map f x let f x = let+ x in x ``` Locating `x` on line 4 gives: ``` $ ocamlmerlin...

Incorrect tracking of identifier through inlcude module type

3

Here is a cram test of the issue: ``` Create a module with an mli file $ cat > foo.ml type t = Foo > module Bar = struct >...

``` module Foo = struct type t = { foo : int ; bar : int } let foo = "hello" end let _ = let foo = 10 in...

Short-paths handles `open` poorly

1

Here's a cram test demonstrating the issue: ``` We get a bad path for `hello` $ cat > foo.ml type t > end > > module Bar = struct >...

Fix inclusion check error message

6

At the moment, when compiling with dune and using a ppx, this is what an inclusion-check error message looks like: ``` File "src/foo.ml", line 1: Error: The implementation src/foo.pp.ml does...