Liad Yosef comments

Results 38 comments of


                                            Liad Yosef

use webpack-node-externals to generate node_modules externals

@jlongster any news on this?

Add fix for $.fn.data calls

@mgol this is an important fix so I do want to implement the changes to this PR, however I cannot attend to it in the next 10 days.

support selector in 'on' function

Thanks. Changed to a limited "closest" check: http://jsfiddle.net/q8grdnxa/1/

support selector in 'on' function

You're right, I already handled that case but didn't clear the selector variable. Fixed now: http://jsfiddle.net/q8grdnxa/2/

Uncaught ReferenceError: require is not defined

@akshaybabajob can you please share your webpack config?

Uncaught ReferenceError: require is not defined

@ericraio Can you share the node stack trace for this exception?

Uncaught ReferenceError: require is not defined

Notice that webpack-node-externals is meant mainly for excluding node modules when building for a library for Node. It leaves the `require(...)` statements, instead of bundling them. `require` is a Node...

Uncaught ReferenceError: require is not defined

@FakhruddinAbdi Are you running your bundle in the browser? `webpack-node-externals` with the default configuration produces bundles that are suitable for commonjs environements (e.g Node)

Base paths on your code that share names with node modules get ignored

@wbobeirne thanks for your feedback. I spent some time thinking how to solve the alias/module issue. It seems that when trying to define if a module is external, Webpack doesn't...

There should be an option to automatically co-whitelist peer-dependencies of a whitelisted module

@MagnusBrzenk @fivethreeo Thank you for your suggestions and interest. If I understand correctly - the request is that all modules in the `allowlist` will have their own dependencies bundled as...