Luke Howard

Results 202 comments of Luke Howard

@nicowilliams it does have a lot of changes but many are Apple and NTLM specific. Since Big Sur, they no longer use it and I'm not sure if the replacement...

This was fixed in 3bcc031939d4f8cf600839d1e92b252c250d4d79, @jaltman will there be an interim release before 8?

@dmulder, where are the redefinition warnings coming from? Perhaps the problem is that they are not including config.h before roken.h?

I'm happy to merge this but, were you having second thoughts?

This appears to have been fixed @jaltman, can we close?

Looks like this could have been introduced in f70ccfa967. The `get_default_cc_type()` function does not respect `KRB5_DEFAULT_CCTYPE`, which is defined differently on Apple platforms.

@nicowilliams, should `get_default_cc_type()` ever return NULL? Some callers assume it never returns NULL, but this also means that `krb5_cc_configured_default_name()` will not execute the code subsequent to its invocation (from `#ifdef...

```diff diff --git a/lib/krb5/cache.c b/lib/krb5/cache.c index a752f65f3..43c936f42 100644 --- a/lib/krb5/cache.c +++ b/lib/krb5/cache.c @@ -283,7 +283,7 @@ get_default_cc_type(krb5_context context, int simple) return context->cc_ops[i]->prefix; } } - return def_cctype ? def_cctype :...

Functions which assume `get_default_cc_type()` does not return NULL: - `krb5_cc_new_unique()` - `krb5_cc_default_sub()`/`krb5_cc_default_for()` (AFAICT) Can return NULL: - `krb5_cc_resolve_sub()` - `krb5_cc_configured_default_name()`