Luke Howard
Luke Howard
I probably won't have an opportunity to look at this for some time, unfortunately. (In the present situation I don't have good access to my development environment.) I'm happy to...
These LGTM, perhaps you can squash into one commit? cc @jaltman
Regarding the krb5 interfaces, it's the same interface with a new plugin which is (more or less!) documented in krb5-plugin.7. For the kadm5 hook API, it's pretty much the same...
`kadm5-hook.h` is a public header, installed into `include/kadm5`. krb5 plugin headers are already installed into `include/krb5`. The new plugin interface is documented in krb5-plugin.7 So, I think we can safely...
Thanks for the thorough report, we should fix this. Does MIT implement this properly? (I did work on that implements but can’t recall offhand.)
That makes sense, I did implement this for MIT in 2009 but my memory is hazy (and am traveling with limited access to internet at the moment). I think the...
Yeah, in-place definitely makes sense in terms of avoiding allocation, but rotating in-place assumes the memory passed by the caller is mutable (which is _probably_ not part of the API...
Depends on #552
> Please rebase now that the fix commits have been merged independent of this PR. Rebased and pushed. It's a while ago since I looked at this, so I can't...
OK, I added a separate commit with `KRB5_ANON_IGNORE_NAME_TYPE` but it needs careful review.