Lari Hotari

Results 996 comments of Lari Hotari

@hamadodene do you use offloading? I found issue https://github.com/apache/pulsar/issues/21737 which could be related in that case.

also https://github.com/apache/pulsar/issues/15464

> Add option in broker and proxy to optionally prevent them from logging role or orignalPrincipal. If the option is activated they will log `[REDACTED]`. Do you have a chance...

> @lhotari I defined two configuration keys for broker and proxy. One anonymizes using SHA-256. The other put REDACTED. Is that ok? @KannarFr good progress, I added review comments.

Please split the PIP document to a separate PR. That's what is usually done. The PIP document PR would get merged before the implementation PR.

When you create the PIP document PR, please make the file name pip-XXX.md since most PIP docs have such file name. You should check the mailing list and existing PRs...

@KannarFr Please remove the PIP document from this PR and rebase this PR. https://github.com/apache/pulsar/blob/master/pip/pip-402.md has been merged.

@KannarFr There are 2 checkstyle errors: ``` Error: src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:[56,8] (imports) UnusedImports: Unused import: org.apache.pulsar.common.util.anonymizer.DefaultRoleAnonymizerType. Error: src/main/java/org/apache/pulsar/common/configuration/anonymizer/DefaultAuthenticationRoleLoggingAnonymizer.java:[1] (javadoc) JavadocPackage: Missing package-info.java file. ``` Please also search the code base for any...

@stillerrr When the client is idle, batchFlushTasks aren't scheduled in the Pulsar client code. The current problem description where it says "when client idle" doesn't make sense to my.

It could be useful to use a real profiler sync as https://github.com/async-profiler/async-profiler to pinpoint the problem.