Lari Hotari
Lari Hotari
[fix][client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted
Closing and reopening to trigger CI with latest master branch changes.
> > I wonder if it would be a viable option to catch exceptions and retry with a read lock if that happens? > > Then we may catch a...
I think that we should revert the migration to RoaringBitSet in branch-3.0, branch-3.2 and branch-3.3 so that we don't need to rush with the solution.
I reverted the changes in branch-3.0, branch-3.2 and branch-3.3. Here's the PR to revert the change in master branch: #22968 . It's better to have a fresh start with a...
> When we do Readonly operations on StampLock based ConcurrentRoaringBitSet, it does faster than ReadWriteLock(about 5 times faster), but in the case we use `ConcurrentRoaringBitSet` is Read and Write(about 1:1)....
> It makes sense, I addressed this, PTAL @dao-jun Looks good, I'll soon review in more detail. Please update the PR title and description so that it describes the motivation...
Since the previous change #22908 was rollbacked by #22968, please rebase the changes.
> Please use write lock for `individualDeletedMessages.resetDirtyKeys();` call in `buildIndividualDeletedMessageRanges` method. This is actually a real bug in the current implementation and needs to be fixed even if we wouldn't...
> > Rename ConcurrentOpenLongPairRangeSet to OpenLongPairRangeSet and mark it as NotThreadSafe. > > I guess this change and the switch to use RoaringBitSet (in version 1.1.0) was lost in rebasing?...
LGTM, good work @dao-jun