Leonard Hecker

Results 689 comments of Leonard Hecker

Was there a reason why we didn't merge this?

To solve this we need to duplicate the existing unindent method: https://github.com/microsoft/edit/blob/d8320588536211765332a1851abde47404ccd63f/src/buffer/mod.rs#L1965-L2040 +1000 bonus points if we can do this by abstracting this into a single `change_indent` function that takes...

> Very poor performance when opening So, is the performance issue with opening files or with searching in them? Your description only talks about the latter. > Search performance problem:...

The overwhelming majority of CPU time is spent in the read syscall, even if the file is fully cached in memory. Whether ropey is used or not would not make...

I'll close this issue for now due to no response to my question. We currently have no plans to address the search performance. Editors specialized for large files may fare...

> I would understand if this behavior is "as-designed" and therefore this converted to a feature request. This is indeed currently as-designed. Finding new profiles is not super expensive, but...

I'll review it again once I get a chance. 🙂

I'll go through this PR after #397 merges, as it introduces the ability to group multiple changes into a single undo. This will be very useful for this PR as...

Looking at [the list of other Spacing Marks](https://codepoints.net/search?GCB=SM) it seems to me like we should assign them a non-zero width. The "spacing" means after all that they occupy their own...

Yeah, that looks a lot better, doesn't it? ![image](https://github.com/user-attachments/assets/24ee0bbc-9a7b-40a1-94e3-f0cc17b30427)