Leonard Hecker

Results 389 comments of Leonard Hecker

The other child processes of Windows Terminal are the shells and console applications you spawn. By the way, when I said that we could check the exit code, I would...

re: https://github.com/microsoft/terminal/pull/16014#discussion_r1334836949 As an experiment we could still try to turn it into a `HWND_MESSAGE` window in e.g. the 1.22 canary. I know you said that it needs `WS_OVERLAPPEDWINDOW` because...

(Oh, it may be worth mentioning for other readers of this issue that I responded over in the mentioned PR, where I felt like it's more appropriate. Here: https://github.com/microsoft/terminal/pull/16014#discussion_r1586293642)

I believe the problem is that you need to pass `SW_SHOWNOACTIVATE` for the child's `ShowWindow` call. That's what we do in conhost's `ITerminalApi`: https://github.com/microsoft/terminal/blob/a0d1329d7aabf72301a0cdaec420bd165a6545d3/src/host/outputStream.cpp#L223

I believe if we go top-down we can similarly decide whether descending in a sub-tree is necessary by checking if the pointer position falls into the current node's rect. However,...

> I'm seeing that this is the preferred solution compared to the older console API [...] That's not quite correct. `WriteConsole` and `WriteFile` are entirely valid ways to write text...

In the native Win32 console API this field is called `dwMaximumWindowSize` in the `CONSOLE_SCREEN_BUFFER_INFO(EX)` struct. It's read-only and these methods generate it: https://github.com/microsoft/terminal/blob/d14524cd4cc4970bb1b6456f9667e2dd661b9854/src/host/screenInfo.cpp#L410-L478 It seems like we should return 65535,65535...

I've got a laptop with touchscreen, I'm on 22635.3575, and I don't have a Shell Handwriting setting: ![image](https://github.com/microsoft/terminal/assets/2256941/76a3e24c-1cc2-4656-8b6f-1f408f4e60d6) Does this only work with pens?

Right... I wrote that "This feature only works when GPU Acceleration is available." text before I added the Graphics API setting (at which time that statement was mostly true), but...

I suspect most people will keep it on the default option "Automatic", in which case Direct2D is only used if the system lacks a GPU (or it's a very old...