Pymake

Open cjw85 opened this issue 1 year ago • 3 comments

This PR redoes https://github.com/lh3/minimap2/pull/868 only it adds the crucial include *.c into the MANIFEST file used to create the source distribution tarball.

It can be tested with:

python setup.py sdist

then navigating to the output directory and installing:

cd dist
pip install mappy-2.28.tar.gz

Aug 14 '24 14:08 cjw85

I've close this for now, as I had a failed build in our CI system. There might be some simple compiler flags to change.

Aug 14 '24 16:08 cjw85

This two stage approach requires -fPIC to be set when building libminimap.a on Linux.

Aug 15 '24 08:08 cjw85

I'm still in two minds as to whether this is the best way to perform the build. It has the advantage of not needing to duplicate and maintain the tortuous logic of the makefile of which things to build, but does require make.

Aug 15 '24 08:08 cjw85