fermi-lite icon indicating copy to clipboard operation
fermi-lite copied to clipboard

Published 20 hours ago • verified publisher icon lh3

bseq1_t --> fseq1_t

Open walaj opened this issue 8 years ago • 3 comments

Hi Heng, In trying to link bwa and fml in the same executable, I ran into an issue where bseq1_t was defined differently in each library. I ended up making a fork that fixed this issue for SeqLib, but am getting some feedback that it would be better to avoid having multiple fml / bwa clones out there and instead just have SeqLib link to the official fml.

Would you be willing to consider a PR that does the minimal amount of re-naming within fml to be able to link to bwa without multiple definition errors?

walaj avatar Jan 27 '17 16:01 walaj

Hi, the following patch fixes the said issue (leaving others I'll discuss with walaj ). Hope this helps, Andreas.

tillea avatar Feb 02 '17 10:02 tillea

Just to let you know: I have uploaded the patched fermi-lite to Debian experimental. It mighht be tested there and if no issues occure this will be moved into main Debian. It would be great if you could take this over into your next release to avoid diversion.

tillea avatar Feb 12 '17 17:02 tillea

Please note: This is fixed by commit e93040b. I have no idea why gitlab merged two different commits to one single pull request. The other commit is addressing #11 . These two commits resolve the coding patches that were applied to the Debian packaging to avoid conflicts with other packages. It would be great if you could apply these and tag a new version. Thanks, Andreas.

tillea avatar Oct 25 '18 12:10 tillea