Guoxiong Li
Guoxiong Li
> > I don't really know whether it is a good idea to has both CSRIssueBot and CSRPullRequestBot. It seems that one CSRBot contains two work items, `IssueWorkItem` and `PullRequestWorkItem`,...
The test `UpdatedIssuePollerTest#testGetUpdatedIssues` and `UpdatedIssuePollerTest#testGetUpdatedCsrIssues` failed on `Windows` platform. It passed locally (linux&x64) and I don't know the failed reason now. And I don't have the windows platform to debug....
> Although two pollers are extracted from the csr module to re-used. But the csr and jep module are not changed because it would improved the complexity of this patch....
> The commands should just add labels and a specific type of comment to the (at least for now) head issue of a PR. No other actor should be touching...
> The ApprovalsPullRequestWorkItem seems redundant to me. The reason we had a separate bot for CSR was that the CheckWorkItem could only trigger on PR updates. The original CSRBot would...
When the developers use the `/issue` command to remove an issue, the previously added labels will always exist in that issue and can't be removed. But I can't find a...
When the developers use the `/issue` command to remove an issue, the previously added labels will always exist in that issue and can't be removed. But I can't find a...
> Can you elaborate on this? As I understand the code, whether computing the threshold at the end of young-gc-pause or at the start of (next) young-gc-pause doesn't make any...
> 1. the printed threshold and age-table are directly related -- the threshold is calculated from the age-table. > 2. the printed threshold and age-table are corresponding to the just...