Guohan Lu

Results 100 comments of Guohan Lu

@jeff-yin , no need to assign. please have reviewer to sign off, then we can merge.

i remember we removed ethtool on the host and use ethtool in the pmon. can you check the commit history to check why we did that?

@mlok-nokia , #15856 just install ethtool directly instead of building from source. there is some other PR that move ethtool into the PMON docker. can you check which PR is...

@dgsudharsan let us know if you have any concern on this one?

for all duplicated drivers in the kernel, please create patch in sonic-linux-kernel, meanwhile do the upstream efforts. we can see whether some of the patch make sense or not. for...

i also see binary files, we do not accept platform binary files

too many duplicated linux kernel modules in this PR. All drivers under this folder (platform/broadcom/sonic-platform-modules-micas/common/modules/linux/) are duplicated from linux kernel. This is cause lots of maintenance issues.

i suggest to have a RO attribute defined to indicate which range the asic support. for example, the traditional range, or this new packet size range. we can say the...