Pddf_support_dell_platforms: Add PDDF support for s52xx dell platforms.

[arun1355492]

Why I did it

Add PDDF support for the dell s52xx platforms.

How I did it

Add PDDF configuration files, scripts and python files.

How to verify it

To switch to PDDF mode run the below command and wait for the system to be ready. pddf_util.py -d switch-pddf

Run the PDDF commnads systemctl | grep -i pddf pddf_fanutil direction pddf_fanutil getspeed pddf_fanutil numfans pddf_fanutil status pddf_psuutil mfrinfo pddf_psuutil numpsus pddf_psuutil seninfo pddf_psuutil status pddf_thermalutil gettemp pddf_thermalutil numthermals pddf_ledutil getstatusled SYS_LED pddf_ledutil getstatusled FAN_LED pddf_ledutil getstatusled FANTRAY1_LED pddf_ledutil getstatusled FANTRAY2_LED pddf_ledutil getstatusled FANTRAY3_LED pddf_ledutil getstatusled FANTRAY4_LED

Note: To switch back to non PDDF mode check help on pddf_util.py -help

• [ ] 202305

Unit Test results: s5232f_pddf_logs.txt s5248f_pddf_logs.txt s5296_pddf_logs.txt s5212f_pddf_logs.txt s5224f_pddf_logs.txt

A picture of a cute animal (not mandatory but encouraged)

[linux-foundation-easycla[bot]]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: arun1355492 / name: Arun Akula (7629d0f15a8fc658bde898ef293efb02a47becfa, 467f3a3acbfe0fb6da567e7ed4a17b821d76f0ad, 32aea9f9a276812a932cb64a19b26115a5708354, 64c230bfdf9299ab0a4828db9f60221c518d6d16, 08e2c03b6a99b8a05a0500a01f1e2135fc1d1a8e, 2a03d84efd43ed523c2af1f1655f28c0cbd076e5, a0d53f5d13c14bfe4789e181c96874f41d30e793, 1626173f4655f97bf5575a33bf71af31c59e9da6)

[arun1355492]

@srideepDell Please review the PR.

[jeff-yin]

@lguohan @zhangyanzhao -- please assign @srideepDell , @rvasanthm , @thaj-deen , @vpsubramaniam , @arunlk-dell to review this Dell platform PR. Also, @FuzailBrcm and @leeprecy from Broadcom, who have expertise in PDDF.

Thanks!

[lguohan]

@jeff-yin , no need to assign. please have reviewer to sign off, then we can merge.

[FuzailBrcm]

@leeprecy @geans-pin Please review these changes

[arun1355492]

could you please use https://github.com/sonic-net/sonic-buildimage/blob/master/platform/broadcom/sonic-platform-modules-dell/common/ipmihelper.py instead of redefining ipmihelper in each platform.

Changed to use from the common folder.

[arun1355492]

From the UT logs, Hardware Revision is displayed as "N/A". Could you please check it?. Also, please attach sonic-mgmt test results.

I have ran sonic-mgmt test for the dell platforms in pddf mode and added required function as part of sonic-mgmt test. Also addressed review comments.

Attaching latest UT logs and sonic-mgmt test case report. Some of the test cases are failed due to name mismatch from the platform.json which will resolved in the future enhancements whenever newer pddf updates.

Platforms s5232f and s5248f does not have platform.json. s5248f will have platform.json from https://github.com/sonic-net/sonic-buildimage/pull/20287/files and s5232f will have platform.json in future updates.

s5212f_logs.txt s5212f_pddf_logs.txt s5224f_logs.txt s5224f_pddf_logs.txt s5232f_logs.txt s5232f_pddf_logs.txt s5248f_logs.txt s5248f_pddf_logs.txt s5296f_logs.txt s5296f_pddf_logs.txt sonic_mgmt_test_report.xlsx