Luis Alvarez D.

Results 84 comments of Luis Alvarez D.

@Emiliano-Bucci Ok so your example looks very similar to my integration tests, that are currently working, so maybe it's because of the version of your Apollo packages, what versions are...

@adamsoffer No afaik 😢

Hi there and sorry for the late review 👋 I'm going to close the PR as the change was merged in https://github.com/vercel/examples/pull/411. Thank you!

Hi there and sorry for the late review! I'm going to close this PR as the changes here were applied to the example in https://github.com/vercel/examples/pull/472

Can confirm. cc @dominiksipowicz can you take a look at this? Also the text can be updated to match our other examples 🤔

There's a basic edge-middleware example with the Build Output API here: https://github.com/vercel/examples/tree/main/build-output-api/edge-middleware. Our documentation isn't very clear and it's Next.js focused, cc @TooTallNate what can we do to improve this?

Can this issue be closed now? cc @leerob

In the current rewrite all static assets will also get rewritten to the assets of the maintenance page, which is intended behavior. It can't just be the browser URL and...

@ah100101 Rename the example and update the readme. Having the action aliasing to production is not ideal, if checks fail the reporting is less useful because there's no open PR,...

If the point of the example is to use the term, then sure. Vercel does trunk based development by default, and that's not clear here. This is a more advanced...