jade comments

Results 267 comments of


                                            jade

feat: support configuring the manifold URL

> One thing missing here is that it won't work when [downloading logs via --trace-id ](https://github.com/lf-/buck2/blob/236e347e3e6a6d09c1bf2b6490d45c24c289f8d1/app/buck2_client/src/commands/log/options.rs#L129-L130). It actually *does* work for this, but only because I simply implemented the `curl`...

feat: support configuring the manifold URL

Looks like a bogus CI failure (or at least one I have nothing to do with). Surprised it builds internally at Facebook given that I suspect I broke a usage...

feat: support configuring the manifold URL

@JakobDegen would you be able to take a look at this PR?

feat: support configuring the manifold URL

Can you take another look? @iguridi

feat: support configuring the manifold URL

Rebased.

Trying to use modifiers when not configured does not error or warn

Confirmed that is the issue, so I am renaming the issue, because the fact it's confusing is equally a problem.

`//A/B/C` is a valid name for `//A/B/C:C`

From #925 > Discussed this with @wavewave. We would really like to have this feature because of Bazel compatibility and dev familiarity (fewer divergences with the command line and less...

`//A/B/C` is a valid name for `//A/B/C:C`

Fixed the broken tests and rebased :)

`//A/B/C` is a valid name for `//A/B/C:C`

@JakobDegen checking in regarding this

`//A/B/C` is a valid name for `//A/B/C:C`

still TODO: address feedback. I need to figure out how to thread the config through.