facebook
feat: support configuring the manifold URL
I have a highly trivial Manifold implementation internally at Mercury for which I would like to set up for buck2 to receive rage and all that at. This allows for fully implementing the build logs feature mentioned in https://github.com/facebook/buck2/issues/441.
There's still a buck2_core::facebook_only() or two that need removed and some more tidying.
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.)
One thing missing here is that it won't work when downloading logs via --trace-id .
It actually does work for this, but only because I simply implemented the curl URL structure in locally-euclidean. It is a little goofy but it works.
How would you like to proceed with fixing this after landing this PR though? Should buck2 just fetch them from the fbcdn (and equivalent) URLs in ManifoldClient? Should it implement the actual Manifold GET API (in which case I can't help you because I don't know what it is)?
Looks like a bogus CI failure (or at least one I have nothing to do with). Surprised it builds internally at Facebook given that I suspect I broke a usage of the API I replaced (ManifoldClient::new), but shrug! Whatever works!