Lexidor Digital

Update Exception::__construct($previous)

11

The type should be nullable Throwable since 4.162.0. There may have been good reasons for leaving it though...

[ Typechecker ] __ConsistentConstruct attribute on a class with a final constructor hides error in the overridden constructor

2

**Describe the bug** Overriding a final method is not allowed. This is also true for constructors. The typechecker flags overrides of final methods. Adding a `__ConsistentConstruct` attribute to the base...

**Describe the bug** Indexing into a shape using `Shapes::at($shape, SomeClass::SOME_CONSTANT)` silently returns `nothing` instead of emitting a typechecker error. **Standalone code, or other way to reproduce the problem** ```HACK final...

[Typechecker] Checking for `\HH\FunctionAttribute` and friends when used as an attribute fails on generic classes

1

### HHVM Version ``` HipHop VM 4.26.0 (rel) Compiler: 1570480091_055726735 Repo schema: e24c730ecd4902e383877e9e82598459f02b76f6 ``` ### Operating System and Version Irrelevant ### Standalone code, or other way to reproduce the problem...

**Describe the bug** Hhvm 4.153 and below interpret `hhvm --hphp -t hhbc --module .` to mean "compile everything in my cwd and all recursive sub directories". Hhvm 4.154 does not...

After doing some work on this, I kinda think we should ban it on traits too. If we only ban final private methods on classes, hh will still accept this...

[ Feature Request ] try {} catch {} multiple-catch

1

**Is your feature request related to a problem? Please describe.** One of the things I "miss" from the PHP days is support for [multiple-catch](https://wiki.php.net/rfc/multiple-catch). This was a nice to have...

Hack is MIT licensed, but [used to be BSD licensed](https://github.com/facebook/hhvm/commit/17db24dcadf0f82f8832c46fb8ed7ab69cbc20ac). The license header used is specific to the project, since it mentions the removed PATENTS file in the Hack directory....

**Describe the bug** `hh_client --lint` believes a variable that is declared outside a lambda can be shadowed inside a lambda. **Standalone code, or other way to reproduce the problem** ```HACK...