Results 125 comments of Lewis Baker

Note that MSVC as of 2017 Update 3 would not currently be able to use such an abstraction as it currently converts from `get_return_object()` return-value into coroutine return-type immediately rather...

Thanks for the detailed analysis. So to summarise the problem occurs in the following situation: * Thread, T1, runs out of work and calls `notify_intent_to_sleep()` which sets `m_isSleeping = true`...

> I see three options: > > 1. Leave it like this, accepting clutter in the history. > 2. Recreating this pull request as a cherry-pick of [0b201f8](https://github.com/lewissbaker/cppcoro/commit/0b201f8aac3787e0037d82a4c298f9c91db8c3f6) > 3....

Feel free to steal bits from libunifex actions config. https://github.com/facebookexperimental/libunifex/blob/master/.github/workflows/libunifex-ci.yml

Which version of gcc are you using? There have been some gcc bugs that have caused weird broken coroutines behaviour that might be causing this. Does the same issue occur...

Thanks for the PR and especially for adding docs! I've added a few minor notes. I won't be able to comment much on the CMake style/structure, though, as I'm a...

> I tried build with LLVM `clang-cl`. It doesn't compile `cppcoro/file.hpp` which include `experimental/filesystem` due to anonymous struct declaration `struct char8_t;` @denchat This seems like an issue with mixing clang-cl...

Are people generally happy that this PR is good to go? There were a few comments that hadn't been responded to, yet. * Note about `/await:heapelide` flag for MSVC Release...

I've added some comments to #110. Perhaps @OleksandrKvl 's comments above could be added to that PR and CMake-related discussion moved there? @dutow Would it be possible to separate this...

cppcoro is now at least buildable under Linux/Clang on the `clang` branch. Still outstanding is the need to work on an implementation of `io_service` using epoll and then subsequent file/socket...