levs57

The comment on this line https://github.com/zcash/halo2/blob/5678a506cbec60d593a21ff618d09bed48abf7f2/halo2_proofs/src/plonk/verifier.rs#L66 suggests that the verify_proof function returns a bool value indicating whether a proof is correct or not. However, this is misleading, in fact, it...

verifier.rs misleading API

2

the halo2_proofs/src/plonk/verifier.rs API is extremely confusing it consists of a single function verify_proof, which sometimes does not verify the proof it has a comment stating it is intended to: ///...

Add preprocessing to challenge API.

1

Right now, we have a challenge API, but it does not allow to use black-box operations on it. For example, if I generate the challenge, I can produce a primitive...