Lev Lazinskiy

Results 36 comments of Lev Lazinskiy

Hey @caarlos0 I've updated everything to the latest version of Dagger and this is now ready for your review and feedback. I have the pipeline flowing on my own fork...

Hey @verdverm we've made some huge progress on performance over the last few releases, could you update to latest and re-run your benchmarks and let us know how it goes?

Thanks so much for re-running, looks like we still got some work to do here, lets try again in the near future :)

Yeah definitely, in the general case we suggest not including node_modules this way. Outside of the performance implications it can also lead to issues between local/ci compatibility. For example if...

> Adding feedback from the docs survey on this topic, may be relevant? > > ![image](https://private-user-images.githubusercontent.com/112123850/367429088-2241ee21-43bb-4d47-805b-7e084e2180ce.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjY2MTU2MzAsIm5iZiI6MTcyNjYxNTMzMCwicGF0aCI6Ii8xMTIxMjM4NTAvMzY3NDI5MDg4LTIyNDFlZTIxLTQzYmItNGQ0Ny04MDViLTdlMDg0ZTIxODBjZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTE3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkxN1QyMzIyMTBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kNGE4Yzg5YzEwNmNkZjYzOWFkZDVkM2MwNjEwOGJhMGE4ZmI0NjIxNWJiMzAwYzgxM2M0ZWE1Y2VhMTY4MGZmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.hvVtasceuf2yUE6QuOHmK-pe5__LpeaNSXQ2t6DaYfc) I think this is a slightly different comment because the objection is piping a...

Couple of thoughts here. The guide feels bit fragmented because were trying to show three things at once but not all of the sections are relevant to them. 1. Daggerize...

@vikram-dagger I hope you dont mind but I went ahead and committed a working version of the two CircleCI files, LMK if you would prefer me to send a PR...

This bit me a bit too, if I have a CLI that is struggling to connect to an engine there is no way for me to kill it, I tried...

This has been fixed in 0.11! 😎

Reviewing this PR caused me to find this https://github.com/dagger/dagger/issues/7895 - it should not block this review, but wanted to make note of the issue so we can polish it later.