dagger icon indicating copy to clipboard operation
dagger copied to clipboard

docs: adapt kubernetes integration page to new template

Open marcosnils opened this issue 1 year ago • 4 comments

Signed-off-by: Marcos Lilljedahl [email protected]

marcosnils avatar Jul 11 '24 19:07 marcosnils

Reviewing this PR caused me to find this https://github.com/dagger/dagger/issues/7895 - it should not block this review, but wanted to make note of the issue so we can polish it later.

levlaz avatar Jul 11 '24 23:07 levlaz

Clicking on the zoom icon in the diagram does not seem to work for me, it just causes the screen to turn blank, its possible its my machine though, could you confirm if this works for you @marcosnils?

Screencast from 2024-07-11 16-10-26.webm

levlaz avatar Jul 11 '24 23:07 levlaz

Clicking on the zoom icon in the diagram does not seem to work for me, it just causes the screen to turn blank, its possible its my machine though, could you confirm if this works for you @marcosnils?

weird.. this works for me indeed.

Reviewing this PR caused me to find this #7895 - it should not block this review, but wanted to make note of the issue so we can polish it later.

thx for reporting. Found the reason why it's happening and just added a comment in that issue :pray:

I propose that we either cut optimization 2 for now, or make sure that we say cloud cache is experimental right now. The way this reads right now implies to me that it's ready for production usage at scale.

I think we can mention cloud cache being experimental for now given that once we launch storage drivers, this approach will be very similar.

marcosnils avatar Jul 12 '24 14:07 marcosnils

just pushed some fixes @levlaz. Mind giving another :eyes: ?

marcosnils avatar Jul 12 '24 14:07 marcosnils