Lev Kokotov comments

Results 134 comments of


                                            Lev Kokotov

Opening connections to pgcat is very slow

I think we are victims of `TCP_NODELAY` (https://www.extrahop.com/company/blog/2016/tcp-nodelay-nagle-quickack-best-practices/). Disabling it should improve this for localhost tests especially where the buffering the socket is actually harmful.

Opening connections to pgcat is very slow

Disable the delay. Enable `TCP_NODELAY`.

pgbench fails when using prepared statement mode and multiple commands outside a transaction

They are supported. This is probably a bug we need to chase down.

Async PG support

I don't think it actually works. I tested it locally, but it fails in CI. Haven't had time to investigate further yet.

PostgresML is spawning too many threads.

`pgml.predict_concurrency` is being passed to XGBoost (and LightGBM I believe) directly via an argument. `OMP_NUM_THREADS` will only work if it's set before the Python runtime is loaded I believe, so...

PostgresML is spawning too many threads.

I've considered this, is there a way to ensure that the function exists before we call it? Nothing wrong with `unsafe` if we've made sure that the code works beforehand...

PostgresML is spawning too many threads.

I agree. We'll accept a patch using `omp_set_num_threads`.

rust-xgboost doesn't build on Mac OS

I went into the bindgen-generated file in `postgresml/pgml-extension/target/debug/build/xgboost-sys-00829db49cff0fdf/out/bindings.rs:365:27` (your path will differ, but it'll be in the error message) and manually removed: ```rust extern "C" { #[link_name = "\u{1}value"] pub...

Error with unclear message

#412 #396

add auth_query_database config

Hey, cool PR. To run the specs locally, you can install Docker & docker-compose & run: ``` bash dev/script/console # Inside the container cargo build cd tests/ruby bundle install bundle...