Lev Kokotov
Lev Kokotov
Oh I see what's going on I think. Let me give this PR a more thorough review and I'll get back to you asap.
We use `once_cell` elsewhere in the code, so it's not a bad idea to use it here too. We can move to `OnceLock` at some point later, for every usage...
I have a couple thoughts, I'll review this PR today/tomorrow. It's the right direction through, so we're very close.
We need to figure out why this doesn't build in CI and then we can probably merge this as is. Without CI, we haven't tested this PR yet. It looks...
> As far as omitting required fields, we could leverage the Option type and check that there aren't any None values before sending a request. That won't be validated until...
Auth query only works with md5 which was removed in Postgres 14.
Only password auth through config is supported right now. If you want passthrough for Postgres 14+, we need to figure out if we can do passthrough with SCRAM or how...
Seems reasonable. A PR is welcome, if you have a moment to provide a fix.
Sounds good! The project is here to stay, thank you for your contributions!
I believe not only pg_query.rs is the most correct Postgres SQL parser but also it's faster than sqlparser. There is a draft PR by another contributor with that integration: https://github.com/postgresml/pgcat/pull/525