Levin Keller
Levin Keller
This is still an issue, isn't it? Can one derive public keys / addresses from some read only data provided to the user of armory in decent way? I would...
This comes from violating [best practices](https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html). >If your types are generated by your source code, publish the types with your source code. Both TypeScript and JavaScript projects can generate types...
This should not be part of a first stable release for 1.0. Not important.
Please first just remove the file from the build and also remove the `module` entry from the `package.json` which should have very little negative impact. Then publish and do your...
If the `module` field is missing any bundler will just take the `main` fields value. I think the only problem might be that projects will have larger bundle size because...
On another note: Why are the build files committed to the codebase? I think they should only be generated locally before a publication, not be part of the git repo.
How about just committing them to a different branch? Like a `github-pages` branch for the generated files? Should do the same trick.
> There are to many different bundlers and projects that consume ethers in various ways, I don’t think I feel comfortable changing the package fields right now. > > I’m...
As you said, the question on whether to "commit or not commit" is a personal preference. Your project, your rules... I never commit a generated file. I also do not...